Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context manager support to client #540

Merged
merged 1 commit into from Mar 9, 2021
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Mar 3, 2021

Closes #538.

This PR adds context manager capabilities to BigQuery client.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from as a code owner Mar 3, 2021
@plamut plamut requested review from steffnay and removed request for Mar 3, 2021
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@plamut plamut requested a review from tswast Mar 3, 2021
tswast
tswast approved these changes Mar 9, 2021
Copy link
Contributor

@tswast tswast left a comment

Love it

Loading

@tswast tswast merged commit d5c7e11 into googleapis:master Mar 9, 2021
10 of 11 checks passed
Loading
@plamut plamut deleted the iss-538 branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants