Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid overly strict dependency on pyarrow 3.x #564

Merged
merged 1 commit into from Mar 22, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 19, 2021

Excludes bignumeric_type from all extra

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #563 馃

Excludes bignumeric_type from all extra
@tswast tswast requested review from a team and shollyman and removed request for a team March 19, 2021 18:40
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2021
@tswast tswast requested a review from plamut March 19, 2021 20:04
@tswast
Copy link
Contributor Author

tswast commented Mar 19, 2021

I suspect that the reason it wasn't failing on Kokoro but it was for me is that our Kokoro setup has an older version of pip that didn't have as strict of dependency resolver.

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the assumption is that users who want BIGNUMERIC support will not use "all", but by explicitly specifying the "bignumeric_type" extra?

The change can be breaking for users that decided to use the fairly recently added BIGNUMERIC support through the "all" extra, but that's probably less bad than everyone else on Python3.6 Mac already using the "all" extra, but are now suddenly facing a regression due to a feature they did not voluntarily request.

@plamut plamut merged commit 97ee6ec into googleapis:master Mar 22, 2021
10 checks passed
@tswast tswast deleted the issue563-pyarrow-bignumeric branch March 22, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit-3.6 session is failing on Mac
3 participants