Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid overly strict dependency on pyarrow 3.x #564

Merged
merged 1 commit into from Mar 22, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Mar 19, 2021

Excludes bignumeric_type from all extra

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #563 馃

Excludes bignumeric_type from all extra
@tswast tswast requested a review from as a code owner Mar 19, 2021
@tswast tswast requested review from shollyman and removed request for Mar 19, 2021
@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@tswast tswast requested a review from plamut Mar 19, 2021
@tswast
Copy link
Contributor Author

@tswast tswast commented Mar 19, 2021

I suspect that the reason it wasn't failing on Kokoro but it was for me is that our Kokoro setup has an older version of pip that didn't have as strict of dependency resolver.

Loading

plamut
plamut approved these changes Mar 20, 2021
Copy link
Contributor

@plamut plamut left a comment

I suppose the assumption is that users who want BIGNUMERIC support will not use "all", but by explicitly specifying the "bignumeric_type" extra?

The change can be breaking for users that decided to use the fairly recently added BIGNUMERIC support through the "all" extra, but that's probably less bad than everyone else on Python3.6 Mac already using the "all" extra, but are now suddenly facing a regression due to a feature they did not voluntarily request.

Loading

@plamut plamut merged commit 97ee6ec into googleapis:master Mar 22, 2021
10 checks passed
Loading
@tswast tswast deleted the issue563-pyarrow-bignumeric branch Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants