Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ConnectionError to default retry #571

Merged
merged 1 commit into from Mar 23, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Mar 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #434 馃

@tswast tswast requested a review from as a code owner Mar 23, 2021
@tswast tswast requested review from shollyman and removed request for Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@tswast tswast merged commit a3edb8b into googleapis:master Mar 23, 2021
10 checks passed
Loading
@tswast tswast deleted the issue434-connection-error-retries branch Mar 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 23, 2021
gcf-merge-on-green bot pushed a commit to googleapis/python-storage that referenced this issue May 20, 2021
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes #426 馃
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes googleapis#426 馃
cojenco added a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
This adds python built-in [ConnectionError](https://docs.python.org/3/library/exceptions.html#ConnectionError) to default retryable types. 
ConnectionError was recently added in the [BigQuery library](googleapis/python-bigquery#571) to allow retries. 

Fixes googleapis#426 馃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants