Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC #638

Merged
merged 5 commits into from Apr 29, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #626 馃

To convey to the observant that these are aliases, even though they could be used (more or less) directly.
This is mainly as a backstop -- DECIMAL requests should be converted to NUMERIC.
@jimfulton jimfulton requested a review from a team April 29, 2021 14:58
@jimfulton jimfulton requested a review from a team as a code owner April 29, 2021 14:58
@jimfulton jimfulton requested review from stephaniewang526 and removed request for a team April 29, 2021 14:58
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2021
@jimfulton jimfulton added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2021
@jimfulton jimfulton added the release blocking Required feature/issue must be fixed prior to next release. label Apr 29, 2021
tswast
tswast approved these changes Apr 29, 2021
@tswast tswast merged commit aa59023 into master Apr 29, 2021
10 checks passed
@tswast tswast deleted the riversnake-626 branch April 29, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants