Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC #638

merged 5 commits into from Apr 29, 2021


Copy link

@jimfulton jimfulton commented Apr 29, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #626 馃

jimfulton added 5 commits Apr 28, 2021
To convey to the observant that these are aliases, even though they could be used (more or less) directly.
This is mainly as a backstop -- DECIMAL requests should be converted to NUMERIC.
tswast approved these changes Apr 29, 2021
@tswast tswast merged commit aa59023 into master Apr 29, 2021
10 checks passed
@tswast tswast deleted the riversnake-626 branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants