Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): fix repr of model reference #66

Merged
merged 2 commits into from Mar 26, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Mar 24, 2020

Fixes #65

plamut
plamut approved these changes Mar 24, 2020
Copy link
Contributor

@plamut plamut left a comment

LGTM, thanks for catching that. 👍

Loading

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Mar 25, 2020

The failed test has nothing to do with the changes here.

Loading

@plamut
Copy link
Contributor

@plamut plamut commented Mar 25, 2020

Indeed, and I will temporarily disable it (as per recent discussion) until that issue gets fixed.

Loading

@plamut
Copy link
Contributor

@plamut plamut commented Mar 26, 2020

@HemangChothani Please just update the branch so that we can merge this, thanks!

Loading

@plamut plamut merged commit 26c6204 into googleapis:master Mar 26, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants