Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct docs for LoadJobConfig.destination_table_description #810

Merged

Conversation

@mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Jul 26, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #811.

@mgorsk1 mgorsk1 requested review from as code owners Jul 26, 2021
@mgorsk1 mgorsk1 requested review from stephaniewang526 and removed request for Jul 26, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jul 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Loading

@mgorsk1
Copy link
Contributor Author

@mgorsk1 mgorsk1 commented Jul 26, 2021

@googlebot I signed it!

Loading

@google-cla
Copy link

@google-cla google-cla bot commented Jul 26, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Loading

@mgorsk1 mgorsk1 force-pushed the docs/correct_load_job_desc branch from f1c0706 to 18aef28 Jul 26, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 26, 2021
@mgorsk1
Copy link
Contributor Author

@mgorsk1 mgorsk1 commented Jul 26, 2021

@googlebot I fixed it.

Loading

@mgorsk1 mgorsk1 force-pushed the docs/correct_load_job_desc branch 4 times, most recently from f5947c0 to 0b95193 Jul 26, 2021
Copy link
Contributor

@plamut plamut left a comment

Thanks for spotting this and taking the initiative to fix it yourself! FWIW, I created an issue and linked it with this PR.

I believe the sentence should be re-worded, after which we can merge this.

Loading

google/cloud/bigquery/job/load.py Outdated Show resolved Hide resolved
Loading
@mgorsk1 mgorsk1 force-pushed the docs/correct_load_job_desc branch from 0b95193 to be067a7 Jul 26, 2021
plamut
plamut approved these changes Jul 26, 2021
Copy link
Contributor

@plamut plamut left a comment

Looks good, thanks again for your contribution!

Loading

@mgorsk1
Copy link
Contributor Author

@mgorsk1 mgorsk1 commented Jul 26, 2021

My pleasure! Thanks for prompt review.

Loading

@plamut plamut changed the title Correct docs for LoadJobConfig docs: correct docs for LoadJobConfig.destination_table_description Jul 26, 2021
@plamut
Copy link
Contributor

@plamut plamut commented Jul 26, 2021

Changed the PR title to make the commit message bot happy, no need to update the PR itself.

Loading

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 26, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit da87fd9 into googleapis:master Jul 26, 2021
12 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants