Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows #946

Merged
merged 6 commits into from Sep 7, 2021

Conversation

@jimfulton
Copy link
Contributor

@jimfulton jimfulton commented Sep 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #894 馃

@jimfulton jimfulton marked this pull request as ready for review Sep 6, 2021
@jimfulton jimfulton requested review from as code owners Sep 6, 2021
@jimfulton jimfulton requested a review from loferris Sep 6, 2021
@jimfulton jimfulton changed the title fix: Arror extension-type metadata not set when calling the REST API or when there are no rows fix: Arrow extension-type metadata not set when calling the REST API or when there are no rows Sep 6, 2021
@jimfulton jimfulton changed the title fix: Arrow extension-type metadata not set when calling the REST API or when there are no rows fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows Sep 6, 2021
Copy link
Contributor

@plamut plamut left a comment

A few nits/questions, but generally looks good to me.

Loading

google/cloud/bigquery/_pandas_helpers.py Show resolved Hide resolved
Loading
google/cloud/bigquery/table.py Show resolved Hide resolved
Loading
tests/system/test_arrow.py Outdated Show resolved Hide resolved
Loading
plamut
plamut approved these changes Sep 7, 2021
Copy link
Contributor

@plamut plamut left a comment

LGTM!

Loading

@jimfulton jimfulton merged commit 864383b into googleapis:main Sep 7, 2021
12 checks passed
Loading
@jimfulton jimfulton deleted the arrow-extension-types-894 branch Sep 7, 2021
Copy link
Contributor

@tswast tswast left a comment

Thanks

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants