Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include key metadata in Job representation #964

Merged
merged 1 commit into from Sep 13, 2021
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Sep 13, 2021

Closes #958.

FWIW, I actually hit the very same test flakiness today, thus adding more info to Job representation will indeed be helpful for investigation.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from tswast Sep 13, 2021
@plamut plamut requested review from as code owners Sep 13, 2021
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
f"{self.__class__.__name__}<"
f"project={self.project}, location={self.location}, id={self.job_id}"
">"
Copy link
Contributor Author

@plamut plamut Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - I chose chevrons over parentheses so that the repr string does not appear as something eval()-able, as it's often the case with repr() output.

Loading

Copy link
Contributor

@tswast tswast Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

Loading

tswast
tswast approved these changes Sep 13, 2021
f"{self.__class__.__name__}<"
f"project={self.project}, location={self.location}, id={self.job_id}"
">"
Copy link
Contributor

@tswast tswast Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

Loading

@tswast tswast merged commit acca1cb into googleapis:main Sep 13, 2021
12 checks passed
Loading
@plamut plamut deleted the iss-958 branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants