Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove py.typed since package fails mypy check #988

Merged
merged 1 commit into from Sep 27, 2021
Merged

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 27, 2021

Reverts #976

Context: https://issues.apache.org/jira/browse/BEAM-12975

@tswast
Copy link
Contributor Author

@tswast tswast commented Sep 27, 2021

Will check the library with mypy before reverting.

Loading

@tswast tswast merged commit 39030f2 into main Sep 27, 2021
14 checks passed
Loading
@tswast tswast deleted the revert-976-py-typed branch Sep 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 27, 2021
@plamut
Copy link
Contributor

@plamut plamut commented Sep 27, 2021

Do we know what exactly caused that error? Is it an issue with some of our annotations, or does mypy behave differently from pytype?

It would be good to fix this while still retaining py.typed, although removing it as a short term fix to unblock maintainers of other is fine.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants