feat: add AvroOptions to configure AVRO external data
#994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Unify `ExternalConfig` class to use `_properties` for everything. This does result in more code, but it should make maintenance easier as it aligns with our other mutable resource classes. * Adds `bigtable_options`, `csv_options`, and `google_sheets_options` properties. This aligns with `parquet_options`.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
plamut
reviewed
Sep 30, 2021
plamut
approved these changes
Sep 30, 2021
| """Additional properties to set if ``sourceFormat`` is set to | ||
| GOOGLE_SHEETS. |
There was a problem hiding this comment.
(nit) Does this fit into a single line? (IIRC the summary in the docs only grabs the first line)
There was a problem hiding this comment.
Not within 79 characters, which is what I've got VS Code configured to wrap at.
Looks like Sphinx did the right thing. Probably because there's no blank line.
There was a problem hiding this comment.
Now that surprised me, but even better then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also:
ExternalConfigclass to use_propertiesfor everything. This doesresult in more code, but it should make maintenance easier as it aligns with
our other mutable resource classes.
bigtable_options,csv_options, andgoogle_sheets_optionsproperties. This aligns with
parquet_options.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
In response to internal request.🦕