Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

feat: add response status to DirectRow.commit() - #128

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
ryanyuan:feature/add-status-to-row-commit
Sep 22, 2020
Merged

feat: add response status to DirectRow.commit()#128
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
ryanyuan:feature/add-status-to-row-commit

Conversation

@ryanyuan

@ryanyuan ryanyuan commented Sep 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #127 🦕

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@ryanyuan
ryanyuan force-pushed the feature/add-status-to-row-commit branch from c671fd3 to 666a908 Compare September 18, 2020 12:17
@ryanyuan ryanyuan changed the title Add response status to DirectRow.commit() feat: add response status to DirectRow.commit() Sep 18, 2020
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Sep 19, 2020
tseaver
tseaver suggested changes Sep 21, 2020
View reviewed changes
Comment thread tests/unit/test_row.py Outdated
Comment thread tests/unit/test_row.py Outdated
Comment thread tests/unit/test_row.py Outdated
Comment thread tests/unit/test_row.py Outdated
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@ryanyuan
ryanyuan requested review from a team and tseaver and removed request for a team September 22, 2020 07:16
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2020
@tseaver

tseaver commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

Unrelated systest failure reported in #140.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 2478bb8 into googleapis:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DirectRow.commit() should return response state

3 participants

@ryanyuan @tseaver @yoshi-kokoro