Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

fix: correct link to docs - #5

Merged
busunkim96 merged 3 commits into
masterfrom
busunkim96-patch-1
Mar 10, 2020
Merged

busunkim96 merged 3 commits into
masterfrom
busunkim96-patch-1

Conversation

@busunkim96

@busunkim96 busunkim96 commented Feb 29, 2020 •

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #8 🦕

@busunkim96
busunkim96 requested a review from leahecole February 29, 2020 01:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 29, 2020
@busunkim96
busunkim96 requested a review from software-dov March 5, 2020 17:28
@plamut plamut added the type: docs Improvement to the documentation for an API. label Mar 10, 2020
Comment thread README.rst Outdated
@busunkim96
busunkim96 requested a review from plamut March 10, 2020 17:45

@plamut plamut left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, the new wording on the README is not ambiguous/misleading anymore. 👍

@busunkim96
busunkim96 merged commit 3d87965 into master Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The client library link is broken

3 participants