Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable self signed jwt if users provide their own credential #86

Merged
merged 5 commits into from Aug 31, 2021

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Aug 30, 2021

Self signed jwt doesn't work for non-prod endpoint, and the workaround is let the customer pass in their own credential to disable self signed jwt, see googleapis/python-aiplatform#553 (comment). However the workaround doesn't work as expected, and this PR fixes the issue.

related PR in gapic-generator-python.

fixes b/197117709

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner Aug 30, 2021
@product-auto-label product-auto-label bot added the api: cloudchannel Issues related to the googleapis/python-channel API. label Aug 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2021
@arithmetic1728 arithmetic1728 merged commit d7c07f8 into main Aug 31, 2021
10 checks passed
@arithmetic1728 arithmetic1728 deleted the arithmetic1728-patch-1 branch Aug 31, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 31, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.2.3](https://www.github.com/googleapis/python-channel/compare/v1.2.2...v1.2.3) (2021-08-31)


### Bug Fixes

* disable self signed jwt if users provide their own credential ([#86](https://www.github.com/googleapis/python-channel/issues/86)) ([d7c07f8](https://www.github.com/googleapis/python-channel/commit/d7c07f8d579ce55ea86520e6a7b7a268befae92d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@parthea parthea mentioned this pull request Sep 3, 2021
1 task
parthea added a commit that referenced this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudchannel Issues related to the googleapis/python-channel API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants