Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a flag to enable/disable gvnic on a node pool #147

Merged
merged 4 commits into from Sep 23, 2021

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 15, 2021

Closes #140

  • Regenerate this pull request now.

PiperOrigin-RevId: 396762326

Source-Link: googleapis/googleapis@1f1d09d

Source-Link: googleapis/googleapis-gen@4bed2d4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGJlZDJkNDZhNWU1YTZkNTM3ZWJjMTUxMTVjZmU0Y2NlNWZjMDQwNSJ9

feat: added node pool level network config
feat: added update support for node pool labels, taints and network tags
feat: added configuration for workload certificates and identity service component
feat: added configuration for node pool defaults, autopilot, logging and monitoring
feat: added the option to specify L4 load balancer configuration and IP v6 configuration
feat: added the option to list supported windows versions
fix: deprecated KALM addon config option
fix: deprecated cluster status condition code
docs: clarified SetNodePoolSize API behavior
fix(deps): require proto-plus 1.15.0

… node pool level network config feat: added update support for node pool labels, taints and network tags feat: added configuration for workload certificates and identity service component feat: added configuration for node pool defaults, autopilot, logging and monitoring feat: added the option to specify L4 load balancer configuration and IP v6 configuration feat: added the option to list supported windows versions fix: deprecated KALM addon config option fix: deprecated cluster status condition code docs: clarified SetNodePoolSize API behavior

PiperOrigin-RevId: 396762326

Source-Link: googleapis/googleapis@1f1d09d

Source-Link: googleapis/googleapis-gen@4bed2d4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGJlZDJkNDZhNWU1YTZkNTM3ZWJjMTUxMTVjZmU0Y2NlNWZjMDQwNSJ9
@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Sep 15, 2021

Unit tests failing with:

==================================== ERRORS ====================================
_ ERROR collecting tests/unit/gapic/container_v1beta1/test_cluster_manager.py __
tests/unit/gapic/container_v1beta1/test_cluster_manager.py:34: in <module>
    from google.cloud.container_v1beta1.services.cluster_manager import (
google/cloud/container_v1beta1/__init__.py:17: in <module>
    from .services.cluster_manager import ClusterManagerClient
google/cloud/container_v1beta1/services/cluster_manager/__init__.py:16: in <module>
    from .client import ClusterManagerClient
google/cloud/container_v1beta1/services/cluster_manager/client.py:34: in <module>
    from google.cloud.container_v1beta1.services.cluster_manager import pagers
google/cloud/container_v1beta1/services/cluster_manager/pagers.py:27: in <module>
    from google.cloud.container_v1beta1.types import cluster_service
google/cloud/container_v1beta1/types/__init__.py:16: in <module>
    from .cluster_service import (
google/cloud/container_v1beta1/types/cluster_service.py:4043: in <module>
    class StatusCondition(proto.Message):
google/cloud/container_v1beta1/types/cluster_service.py:4058: in StatusCondition
    class Code(proto.Enum):
.nox/unit-3-6/lib/python3.6/site-packages/proto/enums.py:34: in __new__
    cls = super().__new__(mcls, name, bases, attrs)
/usr/local/lib/python3.6/enum.py:201: in __new__
    enum_member = __new__(enum_class, *args)
E   TypeError: int() argument must be a string, a bytes-like object or a number, not 'dict'
- generated xml file: /tmpfs/src/github/python-container/unit_3.6_sponge_log.xml -

This looks similar to the error @atulep saw in the generator.

Loading

@bourgeoisor
Copy link

@bourgeoisor bourgeoisor commented Sep 16, 2021

Hi @busunkim96! Do you have some more details on that previous generate error? Are the tests failing here (on #147) due to the generator not generating properly and/or is this something I could look into to help push this PR?

Loading

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 23, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Sep 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Loading

@parthea
Copy link
Contributor

@parthea parthea commented Sep 23, 2021

@googlebot I consent.

Loading

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 23, 2021
@parthea parthea changed the title feat: added a flag to enable/disable gvnic on a node pool feat: added node pool level network config feat: added update support for node pool labels, taints and network tags feat: added configuration for workload certificates and identity service compo... feat: added a flag to enable/disable gvnic on a node pool Sep 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 616b21a into main Sep 23, 2021
10 checks passed
Loading
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-d7bf71c0-3f84-491e-8ace-fac81678e6d9 branch Sep 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 24, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/python-container/compare/v2.7.1...v2.8.0) (2021-09-23)


### Features

* added a flag to enable/disable gvnic on a node pool ([#147](https://www.github.com/googleapis/python-container/issues/147)) ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added configuration for node pool defaults, autopilot, logging and monitoring ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added configuration for workload certificates and identity service component ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added node pool level network config ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added the option to list supported windows versions ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added the option to specify L4 load balancer configuration and IP v6 configuration ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* added update support for node pool labels, taints and network tags ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))


### Bug Fixes

* add 'dict' annotation type to 'request' ([c912605](https://www.github.com/googleapis/python-container/commit/c9126057cde7fc28094785cceab9cf43e42ca8e0))
* deprecated cluster status condition code ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* deprecated KALM addon config option ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
* **deps:** require proto-plus 1.15.0 ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))


### Documentation

* clarified SetNodePoolSize API behavior ([616b21a](https://www.github.com/googleapis/python-container/commit/616b21a6abe2b0c4dd647cf56d544c2aff7312f7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants