Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update README.rst #35

Merged
merged 2 commits into from Jul 18, 2020
Merged

fix: Update README.rst #35

merged 2 commits into from Jul 18, 2020

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jul 16, 2020

Fix the example usage in README

@google-cla google-cla bot added the cla: yes label Jul 16, 2020
Fix the example usage in README
@arithmetic1728 arithmetic1728 force-pushed the arithmetic1728-patch-1 branch from 9d4f5d0 to 02248bf Jul 16, 2020
@arithmetic1728 arithmetic1728 changed the title Update README.rst fix: Update README.rst Jul 16, 2020
@arithmetic1728 arithmetic1728 requested a review from busunkim96 Jul 16, 2020
@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jul 17, 2020

@arithmetic1728 I'd prefer to delete the code from the README. It's probably going to end up doing more harm than good given that it's untested.

Loading

@arithmetic1728
Copy link
Contributor Author

@arithmetic1728 arithmetic1728 commented Jul 17, 2020

@arithmetic1728 I'd prefer to delete the code from the README. It's probably going to end up doing more harm than good given that it's untested.

Yeah, deleted.

Loading

@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jul 18, 2020

@arithmetic1728 Thank you!

Loading

@busunkim96 busunkim96 merged commit e7d1c66 into master Jul 18, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants