Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python package conflicts with crc32c #29

Closed
tswast opened this issue Aug 6, 2020 · 3 comments · Fixed by #30
Closed

Python package conflicts with crc32c #29

tswast opened this issue Aug 6, 2020 · 3 comments · Fixed by #30
Assignees
@andrewsg
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link

tswast commented Aug 6, 2020

This package conflicts with the crc32c package, which is used in projects such as snakemake. This conflict means that older versions of Google client libraries need to be pinned in order to be able to install such packages. See: bioconda/bioconda-recipes#23799
@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2020 •
edited

I guess one could argue that we should namespace the actual package as google.cr3c2c. The ICRAR package certainly predates ours on PyPI.

I haven't checked yet whether google-resumable-media could just use the ICRAR version somehow, allowing us to retire this package.

@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Aug 6, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2020

@dhermes might have some memory about considering use of the ICRAR version.

@tseaver tseaver mentioned this issue Aug 6, 2020
Merged
@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2020

The PR I just opened for GRMP pins to the existing version. If we are going to namespace this package, we would need to make a GRMP release with that new pin, then do the work and make a release here, then update GRMP to use the namespaced version and make a release.

tseaver added a commit to googleapis/google-resumable-media-python that referenced this issue Aug 6, 2020
@tseaver
chore(deps): pin 'google-crc32c < 0.2dev' (#160)
52a322d 
Prepare for upcoming version, which will namespace the module to avoid
conflict with the ICRAR version.

See: googleapis/python-crc32c#29
tseaver added a commit that referenced this issue Aug 6, 2020
@tseaver
breaking: add 'google_' prefix to import name
f188200 
Avoids conflict with ICRAR version.

Closes: #29
@tseaver tseaver mentioned this issue Aug 6, 2020
Merged
tritone pushed a commit to googleapis/google-resumable-media-python that referenced this issue Aug 7, 2020
@tseaver @tritone
chore(deps): pin 'google-crc32c < 0.2dev' (#160)
8878754 
Prepare for upcoming version, which will namespace the module to avoid
conflict with the ICRAR version.

See: googleapis/python-crc32c#29
tseaver added a commit that referenced this issue Aug 7, 2020
@tseaver
breaking: add 'google_' prefix to import name (#30)
b50f43e 
Avoid conflict with ICRAR version.

Closes: #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

breaking: add 'google_' prefix to import name googleapis/python-crc32c
3 participants
@tseaver @tswast @andrewsg