Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attribute error Name while executing the sample code #205

Merged
merged 3 commits into from Jul 2, 2021

Conversation

@vikrant-sinha
Copy link
Contributor

@vikrant-sinha vikrant-sinha commented Jun 21, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #170 馃

cluster.status.State.Name(cluster.status.state), this code will throw an attribute error when executed because it's trying to access State.Name which is not a function of class ClusterStatus.State
A better approach will be to use the cluster.status.state.name as State is of enum type

vikrant-sinha and others added 3 commits Apr 23, 2021
`cluster.status.State.Name(cluster.status.state),`  this code will throw an attribute error when executed because it's trying to access State.Name which is not a function of class ClusterStatus.State
A better approach will be to use the `cluster.status.state.name` as State is of enum type
@vikrant-sinha vikrant-sinha requested a review from as a code owner Jun 21, 2021
@vikrant-sinha vikrant-sinha requested review from dinagraves and removed request for Jun 21, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jun 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 21, 2021
@vikrant-sinha vikrant-sinha changed the title Fix Attribute error Name while executing the snippet #170 fix: Attribute error Name while executing the snippet Jun 21, 2021
@vikrant-sinha
Copy link
Contributor Author

@vikrant-sinha vikrant-sinha commented Jun 21, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 21, 2021
@vikrant-sinha vikrant-sinha changed the title fix: Attribute error Name while executing the snippet fix: Attribute error Name while executing the sample code Jun 21, 2021
@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jul 2, 2021

@billyjacobson Sorry to bother you again, but could you also give access to @dinagraves? Thanks!

@dinagraves dinagraves merged commit cb0328f into googleapis:master Jul 2, 2021
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 27, 2021
馃 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/python-dataproc/compare/v2.4.0...v2.5.0) (2021-07-24)


### Features

* add always_use_jwt_access ([#209](https://www.github.com/googleapis/python-dataproc/issues/209)) ([6aec13c](https://www.github.com/googleapis/python-dataproc/commit/6aec13ce39a2afc0f36878bd61cff1614ec66972))


### Bug Fixes

* Attribute error Name while executing the sample code ([#205](https://www.github.com/googleapis/python-dataproc/issues/205)) ([cb0328f](https://www.github.com/googleapis/python-dataproc/commit/cb0328f3bfec416be9aec34d027fe0f48aab4242))
* **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#227](https://www.github.com/googleapis/python-dataproc/issues/227)) ([5acfcd0](https://www.github.com/googleapis/python-dataproc/commit/5acfcd019dede3684fdf23cbed8bfcebdce606af))
* disable always_use_jwt_access ([#215](https://www.github.com/googleapis/python-dataproc/issues/215)) ([a57e253](https://www.github.com/googleapis/python-dataproc/commit/a57e25388691335b6672613210ee566ed91dc97b))
* enable self signed jwt for grpc ([#233](https://www.github.com/googleapis/python-dataproc/issues/233)) ([7df4fef](https://www.github.com/googleapis/python-dataproc/commit/7df4fefdced730fffd9b994608575512efe8d72a))


### Documentation

* omit mention of Python 2.7 in 'CONTRIBUTING.rst' ([#1127](https://www.github.com/googleapis/python-dataproc/issues/1127)) ([#201](https://www.github.com/googleapis/python-dataproc/issues/201)) ([feea064](https://www.github.com/googleapis/python-dataproc/commit/feea0642ea6dbd6e08d4e52c89789a6b17e4de97))
* add Samples section to CONTRIBUTING.rst ([#228](https://www.github.com/googleapis/python-dataproc/issues/228)) ([3e248c2](https://www.github.com/googleapis/python-dataproc/commit/3e248c29470d635abf0d6fa7ae84dc8370a86bef))

---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants