Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add read_time support for get and query #334

Merged
merged 9 commits into from Jul 15, 2022
Merged

feat: add read_time support for get and query #334

merged 9 commits into from Jul 15, 2022

Conversation

yixiaoshen
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #333 🦕

@yixiaoshen yixiaoshen requested review from a team as code owners July 7, 2022 00:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/python-datastore API. labels Jul 7, 2022
@yixiaoshen
Copy link
Contributor Author

R: @Mariatta

Mariatta
Mariatta suggested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we add in the doc that the read_time is in private preview.

Also seeing failed tests when running it locally.

google/cloud/datastore/client.py Show resolved Hide resolved
google/cloud/datastore/client.py Outdated Show resolved Hide resolved
google/cloud/datastore/client.py Outdated Show resolved Hide resolved
google/cloud/datastore/client.py Outdated Show resolved Hide resolved
google/cloud/datastore/client.py Outdated Show resolved Hide resolved
google/cloud/datastore/query.py Outdated Show resolved Hide resolved
google/cloud/datastore/transaction.py Outdated Show resolved Hide resolved
google/cloud/datastore/transaction.py Outdated Show resolved Hide resolved
tests/unit/test_client.py Show resolved Hide resolved
tests/unit/test_helpers.py Show resolved Hide resolved
yixiaoshen and others added 3 commits July 8, 2022 12:12
@yixiaoshen @Mariatta
Apply suggestions from code review
6f72f72 
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@yixiaoshen @Mariatta
Update google/cloud/datastore/client.py
8273d8c 
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@yixiaoshen
fix timezone issue in read_time unit tests
9a3c904
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022
@yixiaoshen yixiaoshen requested a review from Mariatta July 8, 2022 21:04
@Mariatta Mariatta added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@Mariatta Mariatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
Mariatta
Mariatta approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work!

@Mariatta Mariatta merged commit 58b4b74 into googleapis:main Jul 15, 2022
@release-please release-please bot mentioned this pull request Jul 15, 2022
Merged
This was referenced Aug 4, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

@Mariatta Mariatta

Labels
api: datastore Issues related to the googleapis/python-datastore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support read_time in get and query
3 participants
@yixiaoshen @Mariatta @yoshi-kokoro