Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize / test deprecation of 'Client.reserve_ids' #103

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 7, 2020

Closes #101
Closes #100

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@tseaver tseaver mentioned this pull request Oct 7, 2020
4 tasks
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@tseaver tseaver requested review from frankyn and removed request for frankyn October 8, 2020 18:00
@crwilcox crwilcox requested a review from a team November 3, 2020 23:59
@crwilcox
Copy link
Contributor

crwilcox commented Nov 4, 2020

@tseaver this hasn't been merged yet, curious if you think we should release a 1.9.1 with this so we can deprecate/simplify for 2.0? or if you think this is commonly used enough to justify deprecating in 2.0?

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2020

@crwilcox Given that 2.0.0 is out already, I guess we just merge this and leave the deprecation in place until 3.0.

@crwilcox
Copy link
Contributor

@tseaver that seems reasonable to me.

@tseaver tseaver merged commit 5851522 into master Nov 11, 2020
@tseaver tseaver deleted the 101-reserve_ids-deprecation-cleanup branch November 11, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excess comma in reserve_ids breaks the function
3 participants