Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'Client.entity' helper #239

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2021

Proxy for 'google.cloud.datastore.entity.Entity'.

Proxy for 'google.cloud.datastore.entity.Entity'.
@tseaver tseaver requested a review from crwilcox October 12, 2021 16:50
@tseaver tseaver requested a review from a team as a code owner October 12, 2021 16:50
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Oct 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2021
@crwilcox
Copy link
Contributor

@tseaver what is the purpose of this additon?

@tseaver
Copy link
Contributor Author

tseaver commented Oct 15, 2021

@crwilcox It avoids having to import Entity -- one only needs to import enough to get a Client instance. Key and Query instances can be constructed without imports. I noticed the oddity while working on making the doctest examples testable.

@crwilcox crwilcox merged commit 49d48f1 into main Oct 18, 2021
@crwilcox crwilcox deleted the feat-add-client-entity-proxy branch October 18, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants