Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supply anonymous credentials under emulator #71

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 13, 2020

See: #70.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2020
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

credentials=client._credentials,
_http=client._http,
)
emulator_dataset = os.getenv(GCD_DATASET)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why we don't use the DATASTORE_DATASET defined above here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants