Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use version.py instead of pkg_resources.get_distribution #94

Merged
merged 5 commits into from
Oct 6, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Oct 5, 2020

As part of googleapis/python-api-core#27 and removing reliance on version metadata from pip packaging.

This PR currently alters generated surface.

@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2020
@crwilcox
Copy link
Contributor Author

crwilcox commented Oct 6, 2020

I am merging this, despite manual editing of generated surface. We are moving to a new gen surface for this lib anyway.

@crwilcox crwilcox merged commit ea77534 into googleapis:master Oct 6, 2020
@crwilcox crwilcox removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants