Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

feat: rename dbtime and dbdate dtypes to avoid future conflicts with pandas - #32

Merged
tswast merged 1 commit into
mainfrom
issue31-db-prefix
Oct 14, 2021
Merged

tswast merged 1 commit into
mainfrom
issue31-db-prefix

Conversation

@tswast

@tswast tswast commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #31 🦕

@tswast
tswast requested a review from a team October 14, 2021 14:58
@tswast
tswast requested a review from a team as a code owner October 14, 2021 14:58
@tswast
tswast requested review from a team, busunkim96 and shollyman October 14, 2021 14:58
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Oct 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
@tswast

tswast commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

3.10 failure is expected, as there are pandas wheels yet

@tswast
tswast merged commit 50ea0f7 into main Oct 14, 2021
@tswast
tswast deleted the issue31-db-prefix branch October 14, 2021 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use "db" prefix for dtypes

2 participants