Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

docs(samples): add initial sample codes#13

Merged
gcf-merge-on-green[bot] merged 10 commits intogoogleapis:masterfrom
wuyuexin:sample-code
Sep 30, 2020
Merged

docs(samples): add initial sample codes#13
gcf-merge-on-green[bot] merged 10 commits intogoogleapis:masterfrom
wuyuexin:sample-code

Conversation

@wuyuexin
Copy link
Contributor

@wuyuexin wuyuexin commented Sep 29, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #12 🦕

@wuyuexin wuyuexin requested a review from a team as a code owner September 29, 2020 18:53
@wuyuexin wuyuexin requested review from kurtisvg and removed request for a team September 29, 2020 18:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
kurtisvg
kurtisvg suggested changes Sep 29, 2020
View reviewed changes
wuyuexin and others added 4 commits September 29, 2020 15:03
@wuyuexin @kurtisvg
Update samples/snippets/detect_intent_stream.py
7c93f8e 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@wuyuexin @kurtisvg
Update samples/snippets/detect_intent_stream.py
789541a 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@wuyuexin @kurtisvg
Update samples/snippets/detect_intent_stream.py
cd48cd6 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
changes according to review comments
11c5b1f
@wuyuexin wuyuexin requested a review from kurtisvg September 29, 2020 23:23
kurtisvg
kurtisvg suggested changes Sep 29, 2020
View reviewed changes
samples/snippets/detect_intent_audio.py Outdated
detect_intent_audio(agent, session_id, audio_file_path, language_code)


# [START dialogflow_detect_intent_audio]
Copy link

@kurtisvg kurtisvg Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This region tag should be above the run_sample function

@kurtisvg
Copy link

kurtisvg commented Sep 29, 2020

@busunkim96 I don't see any Kokoro tests running on this repo. Is that intentional?

@busunkim96
Copy link
Contributor

busunkim96 commented Sep 29, 2020

@kurtisvg Kokoro isn't running is because author is outside the org. I also need to add samples configs though. Opened 334490453.

@kurtisvg
Copy link

kurtisvg commented Sep 29, 2020

@kurtisvg Kokoro isn't running is because author is outside the org. I also need to add samples configs though. Opened 334490453.

That was specifically what I was referring too :)

wuyuexin and others added 3 commits September 29, 2020 18:33
@wuyuexin @kurtisvg
Update samples/snippets/detect_intent_audio.py
24b99ad 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@wuyuexin @kurtisvg
Update samples/snippets/detect_intent_audio.py
7cce532 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
changes according to review comments
b0435cb
@wuyuexin wuyuexin requested a review from kurtisvg September 30, 2020 01:44
@product-auto-label product-auto-label bot added api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. samples Issues that are directly related to samples. labels Sep 30, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@kurtisvg
Copy link

kurtisvg commented Sep 30, 2020

@wuyuexin Let me know if you need help merging this.

@wuyuexin
Copy link
Contributor Author

wuyuexin commented Sep 30, 2020

@wuyuexin Let me know if you need help merging this.

Yes, I'm not familiar with the merging process. Is there anything I need to do?

@busunkim96
Copy link
Contributor

busunkim96 commented Sep 30, 2020

👋 There's a small tweak I want to make to the noxfile/noxfile_config. I'll merge it for you right after that @wuyuexin.

Side note, I think I'll have to add another PR template for samples that looks like the one in python-docs-samples.

@wuyuexin wuyuexin requested a review from a team as a code owner September 30, 2020 20:10
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b590308 into googleapis:master Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create sample codes

4 participants

@wuyuexin @kurtisvg @busunkim96 @yoshi-kokoro