-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Adds Python 3.13 support #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…python-dns into feat/add-python-3.13
…python-dns into feat/add-python-3.13
…python-dns into feat/add-python-3.13
|
|
||
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system blacken format" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also have all the unit-<version> from 3.9 to 3.13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are running unit tests in github actions so we do not need to duplicate those tests here in the kokoro session.
Our multi-python docker image does not have python 3.8 and 3.7 wheels due to an issue. We are able to run those unit tests under 3.7 and 3.8 in GitHub (as well as all the others up to 3.14) until we finally ditch 3.7 and 3.8 completely from all the split repos.
owlbot.py
Outdated
| s.replace( | ||
| "noxfile.py", | ||
| 'DEFAULT_PYTHON_VERSION = "3.8"', | ||
| 'DEFAULT_PYTHON_VERSION = "3.10"' | ||
| ) | ||
|
|
||
| s.replace( | ||
| "noxfile.py", | ||
| r'SYSTEM_TEST_PYTHON_VERSIONS: List\[str\] = \["3.8"\]', | ||
| 'SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.10"]' | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can all be done with the following additional parameters in the common.py_library call:
default_python_version="3.10",
system_test_python_versions=["3.10"],
🤖 I have created a release *beep* *boop* --- ## [0.36.0](v0.35.1...v0.36.0) (2025-11-05) ### Features * Add support for Python 3.14 ([#321](#321)) ([99c0adb](99c0adb)) * Adds Python 3.13 support ([#319](#319)) ([ea851ce](ea851ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.36.0](googleapis/python-dns@v0.35.1...v0.36.0) (2025-11-05) ### Features * Add support for Python 3.14 ([#321](googleapis/python-dns#321)) ([99c0adb](googleapis/python-dns@99c0adb)) * Adds Python 3.13 support ([#319](googleapis/python-dns#319)) ([ea851ce](googleapis/python-dns@ea851ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This PR introduces support for Python 3.13 and makes several updates to the CI and testing configuration:
Python 3.13 Support:
CI/Testing Updates:
.github/workflows/lint.ymlfrom 3.8 to 3.10 to mirror other defaults in the nox sessions for system tests, etc.NOX_SESSIONenvironment variable in.kokoro/presubmit/presubmit.cfgto "system blacken format" to control which nox sessions run during presubmitDEFAULT_PYTHON_VERSIONin noxfile.py from 3.8 to 3.10.SYSTEM_TEST_PYTHON_VERSIONSin noxfile.py from 3.8 to 3.10.Owlbot Configuration:
s.replacecalls inowlbot.pyto persist the changes inlint.yml,presubmit.cfg, andnoxfile.pyafter owlbot post-processing. This ensures that the CI environment and test configurations use Python 3.10 by default and that the presubmit runs a specific set of nox sessions.These changes ensure that Python 3.13 is supported and that the CI environment defaults to Python 3.10 for system tests and linting, working around known issues with older Python versions (3.7 and 3.8) in the Kokoro Docker python-multi image.