-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Adds Python 3.13 support #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
12a540b
feat: Adds Python 3.13 support
chalmerlowe e316bf2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 510e019
fix(kokoro): Preserve NOX_SESSION in presubmit.cfg
chalmerlowe 294ecf0
Apply suggestion from @chalmerlowe
chalmerlowe 52d5471
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1aa2893
fix(kokoro): Update path to presubmit.cfg in owlbot.py
chalmerlowe 730de17
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0904f48
Apply suggestion from @chalmerlowe
chalmerlowe f820d65
Apply suggestion from @chalmerlowe
chalmerlowe 1a48a85
Update owlbot.py
chalmerlowe 66e5030
Update .kokoro/presubmit/presubmit.cfg
chalmerlowe e0dcd0f
updates owlbot.py and noxfile.py to use 3.10 for system and linting.
chalmerlowe 63ded6f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 94caad0
updates owlbot.py to try to account for system test
chalmerlowe 396aba4
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] fbc6312
Apply suggestion from @chalmerlowe
chalmerlowe cca6152
Apply suggestion from @chalmerlowe
chalmerlowe 8cea842
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 002c291
Apply suggestion from @chalmerlowe
chalmerlowe 7412511
Apply suggestion from @chalmerlowe
chalmerlowe 8e92bfc
Apply suggestion from @chalmerlowe
chalmerlowe a9b9a98
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] d020cff
Apply suggestion from @chalmerlowe
chalmerlowe b8b5a28
Apply suggestion from @chalmerlowe
chalmerlowe 35cd2c7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] c00b7e0
Merge branch 'feat/add-python-3.13' of https://github.com/googleapis/…
gcf-owl-bot[bot] c1ccaa8
Apply suggestion from @chalmerlowe
chalmerlowe 0cea524
updates lint version to match default of 3.10
chalmerlowe c65a660
updates system test version to match default of 3.10
chalmerlowe f487319
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] e6db188
Merge branch 'feat/add-python-3.13' of https://github.com/googleapis/…
gcf-owl-bot[bot] 80203e3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 09daf39
Merge branch 'feat/add-python-3.13' of https://github.com/googleapis/…
gcf-owl-bot[bot] 858e2f9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0a0fad7
Merge branch 'feat/add-python-3.13' of https://github.com/googleapis/…
gcf-owl-bot[bot] ba92f10
updates lint version to match default of 3.10 redux
chalmerlowe 313059f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 6c71c95
modified the owlbot to take advantage of a capability in common.py_li…
chalmerlowe 31c30bf
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system blacken format" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also have all the
unit-<version>from 3.9 to 3.13?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkevinzheng
We are running unit tests in github actions so we do not need to duplicate those tests here in the kokoro session.
Our multi-python docker image does not have python 3.8 and 3.7 wheels due to an issue. We are able to run those unit tests under 3.7 and 3.8 in GitHub (as well as all the others up to 3.14) until we finally ditch 3.7 and 3.8 completely from all the split repos.