Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

feat: add v1beta2, remove v1beta1#13

Merged
leahecole merged 2 commits into
masterfrom
v1beta2
Apr 1, 2020
Merged

feat: add v1beta2, remove v1beta1#13
leahecole merged 2 commits into
masterfrom
v1beta2

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2020
@busunkim96 busunkim96 requested a review from leahecole March 23, 2020 22:39
@@ -1,24 +1,20 @@
# -*- coding: utf-8 -*-
#
# Copyright 2020 Google LLC
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is github just not understanding the shift between these files correctly? Or should we be concerned about the https -> http and 2020 -> 2019 shift?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard-coded in the generator templates. I'll go poke in the microgenerator to see why this is happening.There's been some talk about fixing this so the original year is preserved, but we've been told it's alright to continue with the status quo for now.

@leahecole leahecole merged commit 1d8efd9 into master Apr 1, 2020
@leahecole leahecole deleted the v1beta2 branch April 1, 2020 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants