Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1beta2, remove v1beta1 #13

Merged
merged 2 commits into from Apr 1, 2020
Merged

feat: add v1beta2, remove v1beta1 #13

merged 2 commits into from Apr 1, 2020

Conversation

busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Mar 23, 2020

No description provided.

@googlebot googlebot added the cla: yes label Mar 23, 2020
@busunkim96 busunkim96 requested a review from leahecole Mar 23, 2020
@@ -1,24 +1,20 @@
# -*- coding: utf-8 -*-
#
# Copyright 2020 Google LLC
Copy link
Contributor

@leahecole leahecole Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is github just not understanding the shift between these files correctly? Or should we be concerned about the https -> http and 2020 -> 2019 shift?

Copy link
Collaborator Author

@busunkim96 busunkim96 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard-coded in the generator templates. I'll go poke in the microgenerator to see why this is happening.There's been some talk about fixing this so the original year is preserved, but we've been told it's alright to continue with the status quo for now.

@leahecole leahecole merged commit 1d8efd9 into master Apr 1, 2020
3 checks passed
@leahecole leahecole deleted the v1beta2 branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants