Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1beta2): enable self signed jwt for grpc #191

Merged
merged 7 commits into from Sep 1, 2021

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Aug 10, 2021

Remove Owlbot v1beta2 customization that passes default scopes as user scopes, so that the auth library does not use the self-signed JWT flow.

Fixes #174

…s user scopes, so that the auth library does not use the self-signed JWT flow.
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@product-auto-label product-auto-label bot added the api: documentai label Aug 10, 2021
@nicain nicain requested a review from busunkim96 Aug 10, 2021
@nicain
Copy link
Contributor Author

@nicain nicain commented Aug 10, 2021

@busunkim96 Are there special Labels necessary to engage owlbot for this change?

@google-cla
Copy link

@google-cla google-cla bot commented Aug 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 12, 2021
@parthea
Copy link
Contributor

@parthea parthea commented Aug 12, 2021

@nicain I'm not aware of any labels. I ran owlbot locally using these steps and pushed to this branch.

# pull the latest docker image for the owlbot-cli
docker pull gcr.io/repo-automation-bots/owlbot-cli:latest
# run the owlbot-cli container to pull changes from googleapis/googleapis-gen
docker run --rm --user $(id -u):$(id -g) -v $(pwd):/repo -w /repo gcr.io/repo-automation-bots/owlbot-cli:latest copy-code
# pull the latest python post processing image
docker pull gcr.io/repo-automation-bots/owlbot-python:latest
# run the python post processing container to synchronize templated files and format the code
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/repo-automation-bots/owlbot-python:latest

@googlebot I consent.

@google-cla
Copy link

@google-cla google-cla bot commented Aug 12, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@parthea
Copy link
Contributor

@parthea parthea commented Aug 12, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 12, 2021
owlbot.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 mentioned this pull request Aug 12, 2021
@parthea parthea marked this pull request as ready for review Sep 1, 2021
@parthea parthea requested a review from as a code owner Sep 1, 2021
parthea
parthea approved these changes Sep 1, 2021
@parthea parthea changed the title fix: Remove Owlbot v1beta2 customization fix(v1beta2): enable self signed jwt for grpc Sep 1, 2021
@parthea parthea added the automerge label Sep 1, 2021
@parthea parthea merged commit 14e7765 into googleapis:main Sep 1, 2021
9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: documentai cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants