Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): new Doc AI samples for v1beta3 #44

Merged
merged 49 commits into from Oct 21, 2020
Merged

docs(samples): new Doc AI samples for v1beta3 #44

merged 49 commits into from Oct 21, 2020

Conversation

aribray
Copy link
Contributor

@aribray aribray commented Oct 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@aribray aribray requested review from as code owners Oct 15, 2020
@aribray aribray requested a review from engelke Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
telpirion
telpirion reviewed Oct 15, 2020
View changes
Copy link
Contributor

@telpirion telpirion left a comment

I think that the sample test are in the wrong place. We typically place the tests in the same folder as the script under test.

E.g. quickstart_test.py is in the same folder as quickstart.py

samples/quickstart_sample_v1beta3.py Outdated Show resolved Hide resolved
samples/process_document_sample_v1beta3.py Outdated Show resolved Hide resolved
samples/batch_process_documents_sample_v1beta3.py Outdated Show resolved Hide resolved
samples/batch_process_documents_sample_v1beta3.py Outdated Show resolved Hide resolved
samples/batch_process_documents_sample_v1beta3.py Outdated Show resolved Hide resolved
samples/quickstart_sample_v1beta3.py Outdated Show resolved Hide resolved
tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated Show resolved Hide resolved
tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated Show resolved Hide resolved
tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated Show resolved Hide resolved
tests/unit/gapic/documentai_v1beta3/quickstart_v1beta3_test.py Outdated Show resolved Hide resolved
@telpirion telpirion requested a review from leahecole Oct 15, 2020
@leahecole leahecole removed the request for review from engelke Oct 15, 2020
@leahecole leahecole added the do not merge label Oct 15, 2020
@leahecole
Copy link
Contributor

@leahecole leahecole commented Oct 15, 2020

putting a do not merge on it right away because the samples checks aren't running - I'll look into that because I'm like 99% sure it's not your fault Ari :)

@leahecole
Copy link
Contributor

@leahecole leahecole commented Oct 15, 2020

blocked by internal CL 337396830 to make checks run

@leahecole
Copy link
Contributor

@leahecole leahecole commented Oct 15, 2020

Alright - CL merged, let's see if the checks show up

@aribray aribray requested a review from leahecole Oct 19, 2020
leahecole
leahecole requested changes Oct 20, 2020
View changes
Copy link
Contributor

@leahecole leahecole left a comment

A couple of hopefully quick things! We're so close!

samples/snippets/batch_process_documents_sample_v1beta3.py Show resolved Hide resolved
samples/snippets/batch_process_documents_sample_v1beta3_test.py Outdated Show resolved Hide resolved
samples/snippets/process_document_sample_v1beta3_test.py Outdated Show resolved Hide resolved
@aribray aribray requested a review from leahecole Oct 20, 2020
@aribray aribray requested a review from leahecole Oct 21, 2020
aribray and others added 3 commits Oct 21, 2020
@aribray @leahecole
Apply suggestions from code review to resolve exception
0849731 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@aribray
resolve exception
61f0c7f
@aribray
lint
80d0fb4
@leahecole leahecole removed the do not merge label Oct 21, 2020
@leahecole leahecole merged commit cc8c58d into googleapis:master Oct 21, 2020
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2021
@release-please
chore: release 0.4.0 (#57)
a75c42a 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.4.0](https://www.github.com/googleapis/python-documentai/compare/v0.3.0...v0.4.0) (2021-03-25)


### Features

* add 'from_service_account_info' factory to clients ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))
* add common resource path helpers, expose client transport ([#43](https://www.github.com/googleapis/python-documentai/issues/43)) ([4918e62](https://www.github.com/googleapis/python-documentai/commit/4918e62033b4c118bf99ba83730377b4ecc86d17))
* add documentai v1 ([#101](https://www.github.com/googleapis/python-documentai/issues/101)) ([74fabb5](https://www.github.com/googleapis/python-documentai/commit/74fabb5e260ecc27e9cf005502d79590fa7f72e4))
* add from_service_account_info factory and fix sphinx identifiers  ([#80](https://www.github.com/googleapis/python-documentai/issues/80)) ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))


### Bug Fixes

* added if statement to filter out dir blob files ([#63](https://www.github.com/googleapis/python-documentai/issues/63)) ([7f7f541](https://www.github.com/googleapis/python-documentai/commit/7f7f541bcf4d2f42b2f619c2ceb45f53c5d0e9eb))
* adds comment with explicit hostname change ([#94](https://www.github.com/googleapis/python-documentai/issues/94)) ([bb639f9](https://www.github.com/googleapis/python-documentai/commit/bb639f9470304b9c408143a3e8091a4ca8c54160))
* fix sphinx identifiers ([d6f183a](https://www.github.com/googleapis/python-documentai/commit/d6f183a696b211c6d29bc28e9bbd0a8537f65577))
* moves import statment inside region tags ([#71](https://www.github.com/googleapis/python-documentai/issues/71)) ([a04fbea](https://www.github.com/googleapis/python-documentai/commit/a04fbeaf026d3d204dbb6c6cecf181068ddcc882))
* remove client recv msg limit and add enums to `types/__init__.py` ([#72](https://www.github.com/googleapis/python-documentai/issues/72)) ([c94afd5](https://www.github.com/googleapis/python-documentai/commit/c94afd55124b0abc8978bf86b84743dd4afb0778))
* removes C-style semicolons and slash comments ([#59](https://www.github.com/googleapis/python-documentai/issues/59)) ([1b24bfd](https://www.github.com/googleapis/python-documentai/commit/1b24bfdfc603952db8d1c633dfde108a396aa707))
* **samples:** swaps 'continue' for 'return' ([#93](https://www.github.com/googleapis/python-documentai/issues/93)) ([dabe48e](https://www.github.com/googleapis/python-documentai/commit/dabe48e8c1439ceb8a50c18aa3c7dca848a9117a))


### Documentation

* fix pypi link ([#46](https://www.github.com/googleapis/python-documentai/issues/46)) ([5162674](https://www.github.com/googleapis/python-documentai/commit/5162674091b9a2111b90eb26739b4e11f9119582))
* **samples:** new Doc AI samples for v1beta3 ([#44](https://www.github.com/googleapis/python-documentai/issues/44)) ([cc8c58d](https://www.github.com/googleapis/python-documentai/commit/cc8c58d1bade4be53fde08f6a3497eb3f79f63b1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole

@telpirion telpirion

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aribray @leahecole @busunkim96 @telpirion @yoshi-kokoro