Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): swaps 'continue' for 'return' #93

merged 2 commits into from Mar 5, 2021

fix(samples): swaps 'continue' for 'return' #93

merged 2 commits into from Mar 5, 2021


Copy link

@telpirion telpirion commented Mar 4, 2021

The for loop that iterates over items in the output Storage bucket has a return rather than a continue. This means that the loop exits if it encounters a non-JSON file before it reaches the output file.

Swapping in continue ensures that we find the JSON file before exiting.

@telpirion telpirion requested a review from as a code owner Mar 4, 2021
@telpirion telpirion requested review from tmatsuo and removed request for Mar 4, 2021
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
@product-auto-label product-auto-label bot added the api: documentai label Mar 4, 2021
@telpirion telpirion requested review from leahecole and munkhuushmgl Mar 4, 2021
@telpirion telpirion changed the title fix: swaps 'continue' for 'return' fix(samples): swaps 'continue' for 'return' Mar 4, 2021
@telpirion telpirion requested a review from leahecole Mar 4, 2021
@telpirion telpirion merged commit dabe48e into master Mar 5, 2021
9 checks passed
@telpirion telpirion deleted the swap-continue branch Mar 5, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\*
## [0.4.0]( (2021-03-25)

### Features

* add 'from_service_account_info' factory to clients ([d6f183a](
* add common resource path helpers, expose client transport ([#43]( ([4918e62](
* add documentai v1 ([#101]( ([74fabb5](
* add from_service_account_info factory and fix sphinx identifiers  ([#80]( ([d6f183a](

### Bug Fixes

* added if statement to filter out dir blob files ([#63]( ([7f7f541](
* adds comment with explicit hostname change ([#94]( ([bb639f9](
* fix sphinx identifiers ([d6f183a](
* moves import statment inside region tags ([#71]( ([a04fbea](
* remove client recv msg limit and add enums to `types/` ([#72]( ([c94afd5](
* removes C-style semicolons and slash comments ([#59]( ([1b24bfd](
* **samples:** swaps 'continue' for 'return' ([#93]( ([dabe48e](

### Documentation

* fix pypi link ([#46]( ([5162674](
* **samples:** new Doc AI samples for v1beta3 ([#44]( ([cc8c58d](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: documentai cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants