Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

feat: use DatetimeWithNanoseconds throughout library#116

Merged
crwilcox merged 5 commits into
googleapis:v2-stagingfrom
crwilcox:v2-staging-minimum-proto-plus
Jul 24, 2020
Merged

feat: use DatetimeWithNanoseconds throughout library#116
crwilcox merged 5 commits into
googleapis:v2-stagingfrom
crwilcox:v2-staging-minimum-proto-plus

Conversation

@crwilcox

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
@crwilcox crwilcox added this to the v2 milestone Jul 17, 2020
@crwilcox
crwilcox requested a review from rafilong July 17, 2020 01:39

@rafilong rafilong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like there are a couple unused imports that are causing lint to fail, but otherwise good!

Comment thread tests/unit/v1/test_base_document.py Outdated
@@ -17,6 +17,8 @@
import mock
import datetime

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused.

@crwilcox
crwilcox merged commit 1801ba2 into googleapis:v2-staging Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants