Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: harden version data gathering against DistributionNotFound#212

Merged
crwilcox merged 2 commits into
googleapis:masterfrom
crwilcox:guard-get-distribution
Oct 6, 2020
Merged

fix: harden version data gathering against DistributionNotFound#212
crwilcox merged 2 commits into
googleapis:masterfrom
crwilcox:guard-get-distribution

Conversation

@crwilcox

@crwilcox crwilcox commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@crwilcox crwilcox requested a review from a team October 6, 2020 19:37
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
@crwilcox crwilcox requested a review from tseaver October 6, 2020 19:37
Comment thread google/cloud/firestore_v1/__init__.py
@tseaver

tseaver commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

I'm not in firestore-dpe, and so my approval doesn't count. :(

@dmahugh dmahugh self-requested a review October 6, 2020 20:44

@BenWhitehead BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stampystamp:

@crwilcox crwilcox merged commit 20b7260 into googleapis:master Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants