Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

chore: sort exceptions properly (manual synth)#256

Merged
crwilcox merged 1 commit into
masterfrom
251-252-manual-synth
Nov 13, 2020
Merged

chore: sort exceptions properly (manual synth)#256
crwilcox merged 1 commit into
masterfrom
251-252-manual-synth

Conversation

@tseaver

@tseaver tseaver commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

I'm hoping that a manual synth will get the hashes in synth.metadata updated all at once, so that future "self" and "synthtoolls" autosynth runs can use the current latest version of googleapis.

  • Restore path helper methods to generated clients.
  • Enforce that 'request' argument to generated client methods is exclusive
    to flattened arguments.
  • Surface 'transport' property for generated clients.

Closes #251
Closes #252

- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
@tseaver
tseaver requested review from a team, busunkim96 and crwilcox November 12, 2020 23:58
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 12, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@tseaver

tseaver commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

@crwilcox, @czahedi looks like @busunkim96 can't approve-for-merge here, either (requiresCodeOwnerReviews: true only allows members of @googleapis/firestore-dpe, looks like).

@crwilcox

Copy link
Copy Markdown
Contributor

@tseaver this description seems inaccurate. Since you have reviewed fully can you describe the changes this is making (it doesn't seem to be about exception order)

@tseaver

tseaver commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

@crwilcox The main point of this PR is to do a full manual synth, trying to get around the fact that the three autosynth PRs can revert to older hashes for (especially, right now) googleapis.

The symptom of that reversion is that the self and synthtools builds are generating using gapic-generator-python 0.33.2, which has the bug of scrambling exception order (see #251, #253).

The rest of the changes (adding path helper methods, transport, etc.) are detailed in the commit description.

@crwilcox
crwilcox merged commit 386e85e into master Nov 13, 2020
@tseaver
tseaver deleted the 251-252-manual-synth branch November 13, 2020 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants