fix: keep live music API keys out of websocket urls#2564
Merged
Conversation
yinghsienwu
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2398.
AsyncLiveMusic.connect()already passes the configured HTTP headers into the websocket connection. For API-key clients those headers includex-goog-api-key, but the live music URI also appended the same key as?key=.... That makes the key show up in URLs whilelive.pyalready authenticates the comparable websocket path via headers only.This removes the query-string key from the live music websocket URI and copies the header dict before passing it to
websockets.connect(), matching the live API path.To verify
UNITTEST_ON_FORGE=1 python -m pytest google/genai/tests/live/test_live_music.py -qpython -m py_compile google/genai/live_music.py google/genai/tests/live/test_live_music.py