Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump release level to production/stable #60

Merged
merged 2 commits into from Sep 29, 2021
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 31, 2021

Fixes #59 馃

Release-As: 1.0.0

@parthea parthea requested a review from as a code owner Jul 31, 2021
@product-auto-label product-auto-label bot added the api: gkehub label Jul 31, 2021
@google-cla google-cla bot added the cla: yes label Jul 31, 2021
@parthea parthea added kokoro:force-run kokoro:run labels Jul 31, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Jul 31, 2021
@parthea parthea added do not merge kokoro:force-run kokoro:run labels Jul 31, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Aug 2, 2021
@parthea
Copy link
Contributor Author

@parthea parthea commented Aug 16, 2021

Wait until 28 days after the release where #63 is solved

@tseaver
Copy link

@tseaver tseaver commented Aug 16, 2021

@parthea

Wait until 28 days after the release where #63 is solved

I presume this is after #64 merges. Is 28 days the standard interval for beta -> ga? Or is that because #64 contains quasi-breaking changes (moving imports)?

@parthea
Copy link
Contributor Author

@parthea parthea commented Aug 17, 2021

I presume this is after #64 merges.

Correct. The 28 day timer will start when we publish the release after #64 is merged.

Is 28 days the standard interval for beta -> ga?

Correct. It is standard interval for beta->ga where we wait 28 days after releasing a client which includes a stable endpoint.

Or is that because #64 contains quasi-breaking changes (moving imports)?

Correct, and I also think it's a good idea to reset the 28 day timer since I don't think we've released a version of this library which included a working v1 client. The last release had a broken v1 client.

@parthea
Copy link
Contributor Author

@parthea parthea commented Aug 27, 2021

Wait until September 20, 2021.

@parthea parthea removed the do not merge label Sep 27, 2021
@parthea parthea requested a review from busunkim96 Sep 27, 2021
@parthea parthea added kokoro:force-run kokoro:run labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Sep 27, 2021
@parthea parthea added the automerge label Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5877ee6 into main Sep 29, 2021
11 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the ga-release branch Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 29, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: gkehub cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants