Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract ContainerEngineHandler into StructuredLogHandler for serverless environments #226

Closed
daniel-sanche opened this issue Mar 18, 2021 · 1 comment
Assignees
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@daniel-sanche
Copy link
Contributor

We currently have the ContainerEngineHandler that writes formatted logs to standard output, which are then parsed and uploaded to stackdriver by fluentd

Serverless environments have issues where logs aren't always properly flushed, so they could benefit by having the same handlers.

WE should abstract ContainerEngineHandler into StructuredLogHandler, to work for other environments

@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 18, 2021
@daniel-sanche daniel-sanche added this to the v2 Update 2 milestone Mar 18, 2021
@daniel-sanche daniel-sanche self-assigned this Mar 18, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 18, 2021
@daniel-sanche
Copy link
Contributor Author

On second thought, we should just remove ContainerEngineHandler in v3.0.0. until then, we should leave it as-is for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant