Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new client options #55

Closed
busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #61
Closed

Implement new client options #55

busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #61
Assignees
Labels
api: logging type: feature request

Comments

@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jul 22, 2020

Add support for the three new client_options quota_project_id, scopes, and credentials_file. These options are implemented on the mirogenerator, so the completion of the migration may automatically fulfill this.

https://googleapis.dev/python/google-api-core/latest/client_options.html

@busunkim96 busunkim96 added the type: feature request label Jul 22, 2020
@product-auto-label product-auto-label bot added the api: logging label Jul 22, 2020
@tseaver tseaver added the status: blocked label Aug 4, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 4, 2020

I believe this work is blocked on merge / release of googleapis/python-cloud-core#15

@tseaver tseaver removed the status: blocked label Aug 4, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 4, 2020

PR needs to pin google-cloud-core >= 1.4.0, < 2.0dev.

@tseaver tseaver moved this from To do to In progress in Add new client options to Python libraries Aug 7, 2020
tseaver added a commit that referenced this issue Aug 12, 2020
@tseaver tseaver closed this in #61 Aug 12, 2020
Add new client options to Python libraries automation moved this from In progress to Done Aug 12, 2020
tseaver added a commit that referenced this issue Aug 12, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 19, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/python-logging/compare/v1.15.1...v2.0.0) (2020-11-19)


###  BREAKING CHANGES

* Use microgenerator for GAPIC layer. See [UPGRADING.md](https://github.com/googleapis/python-logging/blob/master/UPGRADING.md) for details. (#94)
* removes support for webapp2 and other Python2 specific code

### Features

* pass 'client_options' to super ctor ([#61](https://www.github.com/googleapis/python-logging/issues/61)) ([c4387b3](https://www.github.com/googleapis/python-logging/commit/c4387b307f8f3502fb53ae1f7e1144f6284280a4)), closes [#55](https://www.github.com/googleapis/python-logging/issues/55)
* use microgenerator ([#94](https://www.github.com/googleapis/python-logging/issues/94)) ([ff90fd2](https://www.github.com/googleapis/python-logging/commit/ff90fd2fb54c612fe6ab29708a2d5d984f60dea7))


### Bug Fixes

* add default filter settings to list_entries ([#73](https://www.github.com/googleapis/python-logging/issues/73)) ([0a1dd94](https://www.github.com/googleapis/python-logging/commit/0a1dd94811232634fdb849cb2c85bd44e870642f))
* failing CI tests ([#70](https://www.github.com/googleapis/python-logging/issues/70)) ([96adeed](https://www.github.com/googleapis/python-logging/commit/96adeedbda16a5c21651c356261442478aaa867a))


### Code Refactoring

* remove python2 ([#78](https://www.github.com/googleapis/python-logging/issues/78)) ([bf579e4](https://www.github.com/googleapis/python-logging/commit/bf579e4f871c92391a9f6f87eca931744158e31a))


### Documentation

* update docs ([#77](https://www.github.com/googleapis/python-logging/issues/77)) ([bdd9c44](https://www.github.com/googleapis/python-logging/commit/bdd9c440f29d1fcd6fb9545d8465c63efa6c0cea))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging type: feature request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants