Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix logger documentation #100

Merged
merged 2 commits into from Nov 20, 2020
Merged

docs: fix logger documentation #100

merged 2 commits into from Nov 20, 2020

Conversation

busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Nov 19, 2020

image

Verified that the docs show up locally by doing nox -s docs

Fixes #99 馃

@busunkim96 busunkim96 requested review from as code owners Nov 19, 2020
@product-auto-label product-auto-label bot added the api: logging label Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Looks like lint is failing, but after that it LGTM!

@busunkim96 busunkim96 merged commit 6a46b46 into master Nov 20, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants