Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate stream handler #106

Merged
merged 2 commits into from Dec 2, 2020
Merged

fix: remove duplicate stream handler #106

merged 2 commits into from Dec 2, 2020

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Nov 24, 2020

Remove extra StreamHandler. This was resulting in duplicate logs showing up on many GCP environments.
I tested this manually on our supported environments, and removing this doesn't have any negative impacts, and makes GKE and GAE standard much more usable

Fixes #38 馃

@daniel-sanche daniel-sanche requested review from as code owners Nov 24, 2020
@product-auto-label product-auto-label bot added the api: logging label Nov 24, 2020
@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@daniel-sanche daniel-sanche self-assigned this Nov 24, 2020
@daniel-sanche daniel-sanche added the type: bug label Nov 24, 2020
chetan
chetan approved these changes Nov 30, 2020
Copy link

@chetan chetan left a comment

LGTM! I saw this issue as well. Alternatively, I was able to workaround this issue with the following - logging.getLogger().handlers.pop()

0xSage
0xSage approved these changes Dec 1, 2020
@daniel-sanche daniel-sanche merged commit eb5cf40 into master Dec 2, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants