Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix usage guide #140

Merged
merged 5 commits into from Dec 17, 2020
Merged

docs: fix usage guide #140

merged 5 commits into from Dec 17, 2020

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Dec 17, 2020

The usage guide in the docs page had incorrect information, and it contained samples that weren't part of our samples tests. I moved the samples in with the others, and updated them to all work properly.

Long term we should aim to keep most of this usage information in the official gcp docs and link there (or at least use the same samples), but this guide seems like it's still useful for now

Fixes #135 馃

@daniel-sanche daniel-sanche requested review from as code owners Dec 17, 2020
@daniel-sanche daniel-sanche requested review from crwilcox and removed request for Dec 17, 2020
@product-auto-label product-auto-label bot added the api: logging label Dec 17, 2020
@google-cla google-cla bot added the cla: yes label Dec 17, 2020
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Dec 17, 2020

Here is the summary of changes.

You deleted 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@daniel-sanche daniel-sanche merged commit 1ca3981 into master Dec 17, 2020
9 checks passed
@daniel-sanche daniel-sanche deleted the fix-usage-guide branch Dec 17, 2020
snarfed pushed a commit to snarfed/python-logging that referenced this issue Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants