Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add InternalServerError to list of expected errors #151

Merged
merged 2 commits into from Jan 12, 2021
Merged

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jan 11, 2021

We are currently seeing a failure on the continuous CI tests for this repo. It looks like an internal server error is showing up on one of the list_logs calls. This fix adds that exception to the list of exceptions to retry

@daniel-sanche daniel-sanche requested review from as code owners Jan 11, 2021
@product-auto-label product-auto-label bot added the api: logging label Jan 11, 2021
@google-cla google-cla bot added the cla: yes label Jan 11, 2021
@@ -67,7 +68,9 @@ def _list_entries(logger):
:returns: List of all entries consumed.
"""
inner = RetryResult(_has_entries, max_tries=9)(_consume_entries)
outer = RetryErrors((ServiceUnavailable, ResourceExhausted), max_tries=9)(inner)
outer = RetryErrors(
Copy link
Collaborator

@busunkim96 busunkim96 Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK for the purposes of tests. For any changes to automatic retries in the client make sure to reference https://google.aip.dev/194 (it has guidance on error codes that should/shouldn't be retried).

Copy link
Contributor Author

@daniel-sanche daniel-sanche Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks!

@daniel-sanche daniel-sanche merged commit 9bf49f5 into master Jan 12, 2021
8 checks passed
@daniel-sanche daniel-sanche deleted the fix-test branch Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants