Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dict for http request #156

Merged
merged 4 commits into from Jan 14, 2021
Merged

fix: use dict for http request #156

merged 4 commits into from Jan 14, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jan 14, 2021

It was recently reported that the new http request inference is throwing exceptions on at least AppEngine. This PR changes the http_request object to use a standard dict instead of the HttpRequest type, as that seems to be expected by some of the parsers involved.

More tests in this area are needed going forward.

Fixes #155

@daniel-sanche daniel-sanche requested review from as code owners Jan 14, 2021
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@product-auto-label product-auto-label bot added the api: logging label Jan 14, 2021
0xSage
0xSage approved these changes Jan 14, 2021
@daniel-sanche daniel-sanche self-assigned this Jan 14, 2021
@daniel-sanche daniel-sanche merged commit dc26668 into master Jan 14, 2021
8 checks passed
@daniel-sanche daniel-sanche deleted the fix-http-request branch Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants