Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect monitored resources on all GCP environments #200

Merged
merged 29 commits into from Mar 5, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Feb 27, 2021

This PR adds monitored resource detection to all current GCP platforms (GAE, GKE, GCE, GCF, Cloud Run). Previously, we only supported GAE and GKE

I accomplished this by creating a new _monitored_resources.py file that builds canonical resources for each environment, and contains a function to detect the active environment. It should be pretty straight forward, and won't be a disruptive change for existing users

I added new environment tests to check the resource on each environment, and unit tests to test the new file

#183
#57
#7
#10
#201

@product-auto-label product-auto-label bot added the api: logging label Feb 27, 2021
@google-cla google-cla bot added the cla: yes label Feb 27, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Feb 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 27, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Feb 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 27, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 1, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] feature: Cloud Run exports proper monitored resource feat: Cloud Run exports proper monitored resource Mar 2, 2021
@daniel-sanche daniel-sanche linked an issue Mar 2, 2021 that may be closed by this pull request
6 tasks
@daniel-sanche daniel-sanche linked an issue Mar 2, 2021 that may be closed by this pull request
@daniel-sanche daniel-sanche linked an issue Mar 2, 2021 that may be closed by this pull request
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 2, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 2, 2021
@daniel-sanche daniel-sanche linked an issue Mar 2, 2021 that may be closed by this pull request
0xSage
0xSage approved these changes Mar 5, 2021
Copy link

@simonz130 simonz130 left a comment

Great job!

@daniel-sanche daniel-sanche merged commit 4eda681 into master Mar 5, 2021
14 checks passed
@daniel-sanche daniel-sanche deleted the refactor-handlers branch Mar 5, 2021
@MatthijsvW
Copy link

@MatthijsvW MatthijsvW commented Mar 15, 2021

When will the next release be?

@daniel-sanche
Copy link
Contributor Author

@daniel-sanche daniel-sanche commented Mar 15, 2021

It should be today. Just merging in the last PRs and letting tests run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
6 participants