Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger uses default resource #207

Merged
merged 9 commits into from Mar 9, 2021
Merged

fix: logger uses default resource #207

merged 9 commits into from Mar 9, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Mar 8, 2021

We recently made changes to allow default resource auto-detection when using the logging handlers. This PR adds the same feature to regular Logger objects for better feature parity.

This PR also pulls in refactored environment tests from the submodule repo

@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@product-auto-label product-auto-label bot added the api: logging label Mar 8, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT]: tests: refactor environment tests [DRAFT]: fix: logger uses default resource Mar 8, 2021
@daniel-sanche daniel-sanche marked this pull request as ready for review Mar 8, 2021
@daniel-sanche daniel-sanche requested review from as code owners Mar 8, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT]: fix: logger uses default resource fix: logger uses default resource Mar 8, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 9, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 9, 2021
@simonz130 simonz130 added the type: feature request label Mar 9, 2021
@daniel-sanche daniel-sanche merged commit 0f90a79 into master Mar 9, 2021
15 checks passed
@daniel-sanche daniel-sanche deleted the refactor-python-env branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants