Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert default resource behavior to avoid breaking changes #237

Merged
merged 5 commits into from Mar 24, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Mar 23, 2021

We recently added some changes to better auto-detect monitored resources in the environment (#200, #207). unfortunately, some of these changes ended up breaking existing workflows, which relied on a defailt global resource (#233).

This PR reverts auto-detection in the case where the API previously provided a default behavior. An auto-detected resource will still be added when using setup_logging, as that is in line with the existing API contract.

This PR will be reverted at version v3.0.0 to make resource auto-detection the standard

@daniel-sanche daniel-sanche requested review from as code owners Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@product-auto-label product-auto-label bot added the api: logging label Mar 23, 2021
0xSage
0xSage approved these changes Mar 23, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 23, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 24, 2021
@daniel-sanche daniel-sanche merged commit 24a0a5e into master Mar 24, 2021
15 checks passed
@daniel-sanche daniel-sanche deleted the rollback branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants