Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect project from environment instead of from logger #238

Merged
merged 4 commits into from Mar 24, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Mar 23, 2021

It has been reported that some logs show GCP projects that don't line up with where the code is actually running. THis PR fixes the issue by extracting the project directly from the environment

@daniel-sanche daniel-sanche requested review from as code owners Mar 23, 2021
@product-auto-label product-auto-label bot added the api: logging label Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
0xSage
0xSage approved these changes Mar 23, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 24, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 24, 2021
@daniel-sanche daniel-sanche merged commit 813b97c into master Mar 24, 2021
15 checks passed
@daniel-sanche daniel-sanche deleted the detect-project branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants