Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve source location overrides #258

Merged
merged 11 commits into from Apr 20, 2021
Merged

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Apr 15, 2021

  • I improved how source_entries are handled in the CloudLoggingFilter, to better match the LogEntry spec
  • I added a bunch of tests around user overrides for http_request, trace, resource, and source_location fields

@daniel-sanche daniel-sanche requested review from as code owners Apr 15, 2021
@product-auto-label product-auto-label bot added the api: logging label Apr 15, 2021
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Apr 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 15, 2021
@daniel-sanche daniel-sanche changed the base branch from master to v2_update_2 Apr 15, 2021
@daniel-sanche daniel-sanche changed the title DRAFT: Improve source location feat: Improve source location overrides Apr 16, 2021
@daniel-sanche daniel-sanche merged commit 6b10b74 into v2_update_2 Apr 20, 2021
2 of 7 checks passed
@daniel-sanche daniel-sanche deleted the improve-source-location branch Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants