Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom labels with standard library logging #264

Merged
merged 21 commits into from Apr 22, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Apr 20, 2021

The library now fully supports passing in extra labels when logging though the standard library

I also added a number of unit and environment tests around this new functionality

@daniel-sanche daniel-sanche requested review from as code owners Apr 20, 2021
@product-auto-label product-auto-label bot added the api: logging label Apr 20, 2021
@daniel-sanche daniel-sanche changed the base branch from master to v2_update_2 Apr 20, 2021
@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Apr 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 20, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] allow custom labels with standard library logging feat: allow custom labels with standard library logging Apr 20, 2021
user_labels = getattr(record, "labels", {})
record.total_labels = {**self.default_labels, **user_labels}
record.total_labels_str = ", ".join(
[f'"{k}": "{v}"' for k, v in record.total_labels.items()]
Copy link
Contributor

@0xSage 0xSage Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, would this work if users provided nested labels? actually, do we/do we not allow nested labels?

0xSage
0xSage approved these changes Apr 22, 2021
@daniel-sanche daniel-sanche merged commit fe4de39 into v2_update_2 Apr 22, 2021
15 checks passed
@daniel-sanche daniel-sanche deleted the override_labels branch Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants