Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support span inference #267

Merged
merged 12 commits into from May 3, 2021
Merged

feat: support span inference #267

merged 12 commits into from May 3, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Apr 22, 2021

This PR adds automatic span detection, and allows users to override it by sending spanId in the extras dictionary.

The span format seems to be underdocument, so I based my span capture logic on what the go library is doing.

@daniel-sanche daniel-sanche requested review from as code owners Apr 22, 2021
@product-auto-label product-auto-label bot added the api: logging label Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@daniel-sanche daniel-sanche added the kokoro:run label Apr 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Apr 22, 2021
@daniel-sanche daniel-sanche added the kokoro:run label Apr 22, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Apr 23, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run kokoro:force-run labels Apr 23, 2021
google/cloud/logging_v2/handlers/_helpers.py Outdated Show resolved Hide resolved
@daniel-sanche daniel-sanche merged commit fcd26eb into v2_update_2 May 3, 2021
15 of 16 checks passed
@daniel-sanche daniel-sanche deleted the support_spans branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants