Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed region format on serverless #291

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented May 10, 2021

Changed the region format for GCF and Cloud Run to use the last path component, instead of the entire path returned from metadataserver ( us-central1 instead of projects/xxxxxx/regions/us-central1 )

Fixes #284

@daniel-sanche daniel-sanche requested review from as code owners May 10, 2021
@product-auto-label product-auto-label bot added the api: logging label May 10, 2021
@google-cla google-cla bot added the cla: yes label May 10, 2021
@daniel-sanche daniel-sanche merged commit 360d3d2 into master May 10, 2021
16 of 17 checks passed
@daniel-sanche daniel-sanche deleted the fix-functions-region branch May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants